[alsa-devel] [PATCH] Fix for Lenovo B50-70 inverted internal microphone bug.

[Takashi Iwai]

On Tue, 14 May 2019 16:18:38 +0200,
MichaX2 Wadowski wrote:
> 
> On 14.05.2019 15:02, Takashi Iwai wrote:
> > On Mon, 13 May 2019 23:25:36 +0200,
> > MichaX2 Wadowski wrote:
> >>
> >> Add patch for realtek codec in Lenovo B50-70.
> >> Bugzilla: https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/1524215
> >>
> >> Signed-off-by: Michał Wadowski <wadosm at gmail.com>
> > 
> > Thanks for the patch.
> > 
> > Actually this seems problematic: the added PCI SSID (17aa:3978) does
> > already exist for Ideapad Y410P.  That is, we need to replace the
> > entry, not just adding.  The existing quirk is only about the noise
> > fix and it didn't seem help in a later kernel version, in anyway, so
> > it should be OK to replace with the new quirk.
> 
> I also saw this conflict, but I didn't know what should I do with this.
> If you say that existing fix for Ideapad Y410P is not necessary now, I replace this with Lenovo B50-70 fix.

I guess that'd be OK, but of course, it'd be good if you mention about
the replacement in the patch description.

> > Also, I wonder whether the existing quirk
> > ALC269_FIXUP_DMIC_THINKPAD_ACPI works on your device.  Could you check
> > it?
> > 
> > 
> > thanks,
> > 
> > Takashi
> 
> Yes, quirk ALC269_FIXUP_DMIC_THINKPAD_ACPI works fine on my device.
> My laptop uses ALC233, so I created separated quirk, but finally it does the same thing.
> Should I remove ALC233_FIXUP_INV_DMIC and replace it with ALC269_FIXUP_DMIC_THINKPAD_ACPI?

No need for rename.  It's compatible with ALC269, after all.


thanks,

Takashi