[alsa-devel] [PATCH 2/2] ASoC: SOF: core: fix undefined nocodec reference

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Wed May 8 18:21:36 CEST 2019



On 5/8/19 1:27 AM, Mark Brown wrote:
> On Tue, May 07, 2019 at 11:32:36AM -0500, Pierre-Louis Bossart wrote:
>> The existing code mistakenly uses IS_ENABLED in C code instead of as
>> in conditional compilation, leading to the following error:
> 
>> ld: sound/soc/sof/core.o: in function `sof_machine_check':
>> sound/soc/sof/core.c:279: undefined reference to `sof_nocodec_setup'
> 
> There's nothing wrong with using IS_ENABLED() in C code - it can be
> cleaner than using an ifdef to help the compiler eliminate unneeded
> code.

Agree, and we do make use of it. In this case it wasn't smart though.


More information about the Alsa-devel mailing list