[alsa-devel] [PATCH] ASoC: rt1308: Add RT1308 amplifier driver

[Derek [方德義]]

> Subject: Re: [PATCH] ASoC: rt1308: Add RT1308 amplifier driver
> 
> On Tue, Apr 23, 2019 at 01:39:59PM +0000, Derek wrote:
> 
> > > On Wed, Apr 17, 2019 at 11:40:28AM +0000, Derek wrote:
> 
> > > Please fix your mail client to word wrap within paragraphs at
> > > something substantially less than 80 columns.  Doing this makes your
> > > messages much easier to read and reply to.

Sorry for the neglect of mail format. I will pay attention.

> Please don't ignore review comments, people are generally making them for a
> reason and are likely to have the same concerns if issues remain 
> unaddressed.
> Having to repeat the same comments can get repetitive and make people
> question the value of time spent reviewing.  If you disagree with the review
> comments that's fine but you need to reply and discuss your concerns so that
> the reviewer can understand your decisions.
> 
> > > > > The ones here with comments look an awful lot like they're
> > > > > system specific config which should be left up to either
> > > > > platform data (or DT/ACPI configuration) or done at runtime
> > > > > (like gains).  Some of the others like the pads configuration might
> > > > > also fit into that.
> 
> > > > We don't open the DA gain setting for user at runtime, so have to
> > > > set a default level in the init list.
> 
> > > That's not the way Linux drivers generally work...  is there some
> > > technical reason for that or is it just some kind of policy decision?
> 
> > Maybe I could add a gain control for the user and set the gain to safety
> >  max level in init list for speaker protection.
> 
> The maximum volume can be limited with snd_soc_limit_volume() but if the
>  limit is for the speaker then that's machine dependent anyway.

The maximum volume setting is temporarily not machine dependent.
It avoids harming if any machine doesn't set the limit volume.


> ------Please consider the environment before printing this e-mail.