[alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

[Pierre-Louis Bossart]

On 5/6/19 10:34 PM, M R, Sathya Prakash wrote:
> 
> 
> -----Original Message-----
> From: Pierre-Louis Bossart [mailto:pierre-louis.bossart at linux.intel.com]
> Sent: Tuesday, May 7, 2019 7:11 AM
> To: Evan Green <evgreen at chromium.org>; Liam Girdwood <liam.r.girdwood at linux.intel.com>; Mark Brown <broonie at kernel.org>
> Cc: M, Naveen <naveen.m at intel.com>; M R, Sathya Prakash <sathya.prakash.m.r at intel.com>; Ben Zhang <benzh at chromium.org>; Rajat Jain <rajatja at chromium.org>; Jaroslav Kysela <perex at perex.cz>; alsa-devel at alsa-project.org; linux-kernel at vger.kernel.org; Takashi Iwai <tiwai at suse.com>; Liam Girdwood <lgirdwood at gmail.com>
> Subject: Re: [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID
> 
> 
> 
> On 5/6/19 5:53 PM, Evan Green wrote:
>>> Add support for Intel Comet Lake platforms by adding a new Kconfig for
>>> CometLake and the appropriate PCI ID.
> 
>> This is odd. I checked internally a few weeks back and the CML PCI ID was 9dc8, same as WHL and CNL, so we did not add a PCI ID on purpose. To the best of my knowledge SOF probes fine on CML and the known issues can be found on the SOF github [1].
> 
> The PCI ID change is seen on later production Si versions. The PCI ID is 02c8.

we must be talking about a different skew. I'll check, give me a couple 
of days.

> 
>> Care to send the log of sudo lspci -s 0:1f.3 -vn ?
> 
> Here you go:
> localhost ~ # sudo lspci -s 0:1f.3 -vn
> 00:1f.3 0401: 8086:02c8
>          Subsystem: 8086:7270
>          Flags: fast devsel, IRQ 11
>          Memory at d1114000 (64-bit, non-prefetchable) [size=16K]
>          Memory at d1000000 (64-bit, non-prefetchable) [size=1M]
>          Capabilities: [50] Power Management version 3
>          Capabilities: [80] Vendor Specific Information: Len=14 <?>
>          Capabilities: [60] MSI: Enable- Count=1/1 Maskable- 64bit+
> 
> 
> [1]
> https://github.com/thesofproject/sof/issues?q=is%3Aopen+is%3Aissue+label%3ACML
>>
>> Signed-off-by: Evan Green <evgreen at chromium.org>
>> ---
>>
>>    sound/soc/sof/intel/Kconfig | 16 ++++++++++++++++
>>    sound/soc/sof/sof-pci-dev.c |  4 ++++
>>    2 files changed, 20 insertions(+)
>>
>> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
>> index 32ee0fabab92..0b616d025f05 100644
>> --- a/sound/soc/sof/intel/Kconfig
>> +++ b/sound/soc/sof/intel/Kconfig
>> @@ -24,6 +24,7 @@ config SND_SOC_SOF_INTEL_PCI
>>    	select SND_SOC_SOF_CANNONLAKE  if SND_SOC_SOF_CANNONLAKE_SUPPORT
>>    	select SND_SOC_SOF_COFFEELAKE  if SND_SOC_SOF_COFFEELAKE_SUPPORT
>>    	select SND_SOC_SOF_ICELAKE     if SND_SOC_SOF_ICELAKE_SUPPORT
>> +	select SND_SOC_SOF_COMETLAKE   if SND_SOC_SOF_COMETLAKE_SUPPORT
>>    	help
>>    	  This option is not user-selectable but automagically handled by
>>    	  'select' statements at a higher level @@ -179,6 +180,21 @@ config
>> SND_SOC_SOF_ICELAKE
>>    	  This option is not user-selectable but automagically handled by
>>    	  'select' statements at a higher level
>>    
>> +config SND_SOC_SOF_COMETLAKE
>> +	tristate
>> +	select SND_SOC_SOF_CANNONLAKE
>> +	help
>> +	  This option is not user-selectable but automagically handled by
>> +	  'select' statements at a higher level
>> +
>> +config SND_SOC_SOF_COMETLAKE_SUPPORT
>> +	bool "SOF support for CometLake"
>> +	help
>> +	  This adds support for Sound Open Firmware for Intel(R) platforms
>> +	  using the Cometlake processors.
>> +	  Say Y if you have such a device.
>> +	  If unsure select "N".
>> +
>>    config SND_SOC_SOF_HDA_COMMON
>>    	tristate
>>    	select SND_SOC_SOF_INTEL_COMMON
>> diff --git a/sound/soc/sof/sof-pci-dev.c b/sound/soc/sof/sof-pci-dev.c
>> index b778dffb2d25..5f0128337e40 100644
>> --- a/sound/soc/sof/sof-pci-dev.c
>> +++ b/sound/soc/sof/sof-pci-dev.c
>> @@ -353,6 +353,10 @@ static const struct pci_device_id sof_pci_ids[] = {
>>    #if IS_ENABLED(CONFIG_SND_SOC_SOF_ICELAKE)
>>    	{ PCI_DEVICE(0x8086, 0x34C8),
>>    		.driver_data = (unsigned long)&icl_desc},
>> +#endif
>> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_COMETLAKE)
>> +	{ PCI_DEVICE(0x8086, 0x02c8),
>> +		.driver_data = (unsigned long)&cnl_desc},
>>    #endif
>>    	{ 0, }
>>    };
>>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>