[alsa-devel] [PATCH 2/3] ASoC: SOF: Fix a compile warning with CONFIG_PCI=n

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon May 6 17:40:48 CEST 2019


On 5/6/19 10:02 AM, Takashi Iwai wrote:
> A trivial fix for the randconfig build error:
>    sound/soc/sof/ops.c:20:6: warning: ‘ret’ is used uninitialized in this function [-Wuninitialized]
> 
> Fixes: d1d95fcb63e3 ("ASoC: SOF: Add DSP HW abstraction operations")
> Signed-off-by: Takashi Iwai <tiwai at suse.de>

I remember fixing this, probably never applied it to the right branch 
:-( Thanks Takashi.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>


> ---
>   sound/soc/sof/ops.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/ops.c b/sound/soc/sof/ops.c
> index 80f907740b82..7a27c3b719e7 100644
> --- a/sound/soc/sof/ops.c
> +++ b/sound/soc/sof/ops.c
> @@ -17,7 +17,7 @@ bool snd_sof_pci_update_bits_unlocked(struct snd_sof_dev *sdev, u32 offset,
>   {
>   	struct pci_dev *pci = to_pci_dev(sdev->dev);
>   	unsigned int old, new;
> -	u32 ret;
> +	u32 ret = 0;
>   
>   	pci_read_config_dword(pci, offset, &ret);
>   	old = ret;
> 



More information about the Alsa-devel mailing list