[alsa-devel] [RFC PATCH 6/7] soundwire: cadence_master: add debugfs register dump

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon May 6 16:50:26 CEST 2019


>> +void sdw_cdns_debugfs_init(struct sdw_cdns *cdns, struct dentry *root)
>> +{
>> +	debugfs_create_file("cdns-registers", 0400, root, cdns, &cdns_reg_fops);
>> +}
>> +EXPORT_SYMBOL(sdw_cdns_debugfs_init);
> 
> Don't wrap debugfs calls with export symbol without using
> EXPORT_SYMBOL_GPL() or you will get grumpy emails from me :)

Yes, that's a miss. I've already seen this comment and fixed it for SOF, 
I should have thought about it for SoundWire, my bad.


More information about the Alsa-devel mailing list