[alsa-devel] [PATCH v2 1/2] ALSA: hda/hdmi - Read the pin sense from register when repolling

Takashi Iwai tiwai at suse.de
Mon May 6 16:26:59 CEST 2019


On Mon, 06 May 2019 16:09:31 +0200,
Hui Wang wrote:
> 
> The driver will check the monitor presence when resuming from suspend,
> starting poll or interrupt triggers. In these 3 situations, the
> jack_dirty will be set to 1 first, then the hda_jack.c reads the
> pin_sense from register, after reading the register, the jack_dirty
> will be set to 0. But hdmi_repoll_work() is enabled in these 3
> situations, It will read the pin_sense a couple of times subsequently,
> since the jack_dirty is 0 now, It does not read the register anymore,
> instead it uses the shadow pin_sense which is read at the first time.
> 
> It is meaningless to check the shadow pin_sense a couple of times,
> we need to read the register to check the real plugging state, so
> we set the jack_dirty to 1 in the hdmi_repoll_work().
> 
> Signed-off-by: Hui Wang <hui.wang at canonical.com>

Thanks, applied both patches.
They deserve for Cc-to-stable, so I added it.


Takashi


More information about the Alsa-devel mailing list