[alsa-devel] [PATCH 01/14] soundwire: fix kconfig help format

Vinod Koul vkoul at kernel.org
Thu May 2 17:15:02 CEST 2019


On 02-05-19, 17:07, Greg KH wrote:
> On Thu, May 02, 2019 at 04:29:17PM +0530, Vinod Koul wrote:
> > Move to help format instead of --help-- as that is not recommended and
> > this makes file consistent with other instance
> > 
> > Signed-off-by: Vinod Koul <vkoul at kernel.org>
> > ---
> >  drivers/soundwire/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> > index 84876a74874f..53b55b79c4af 100644
> > --- a/drivers/soundwire/Kconfig
> > +++ b/drivers/soundwire/Kconfig
> > @@ -28,7 +28,7 @@ config SOUNDWIRE_INTEL
> >  	select SOUNDWIRE_CADENCE
> >  	select SOUNDWIRE_BUS
> >  	depends on X86 && ACPI && SND_SOC
> > -	---help---
> > +	help
> >  	  SoundWire Intel Master driver.
> >  	  If you have an Intel platform which has a SoundWire Master then
> >  	  enable this config option to get the SoundWire support for that
> > -- 
> > 2.20.1
> > 
> 
> Huh?
> 
> Pierre-Louis sent this patch before you did.  Why did you just rewrite
> the changelog text a bit and then ignore his authorship and
> signed-off-by?

This is not *that* instance! The one Pierre changed was for symbol
"SOUNDWIRE" and is already applied [1] this is for SOUNDWIRE_INTEL which
is another instance. If you have looked or cared, even the log mentions
"makes file consistent with other instance" 

This series is on *top* on the "whole" series from Pierre

> That's a really really shitty thing to do, I'm going to go take his
> version of these patches instead, let me see how they line up...

Honestly, this is a terrible accusation, seems everyone is quick to jump
and yell at others. I asking for an apology.

-- 
~Vinod


More information about the Alsa-devel mailing list