[alsa-devel] [RFC PATCH asoc] ASoC: wm_adsp: wm_adsp1_ops can be static

Charles Keepax ckeepax at opensource.cirrus.com
Tue Mar 19 18:37:50 CET 2019


On Tue, Mar 19, 2019 at 11:00:06PM +0800, kbuild test robot wrote:
> 
> Fixes: 4e08d50d1fb6 ("ASoC: wm_adsp: Factor out DSP specific operations")
> Signed-off-by: kbuild test robot <lkp at intel.com>
> ---
>  wm_adsp.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
> index 644aaf1..2a9554d 100644
> --- a/sound/soc/codecs/wm_adsp.c
> +++ b/sound/soc/codecs/wm_adsp.c
> @@ -306,8 +306,8 @@
>  #define HALO_MPU_VIO_ERR_SRC_MASK           0x00007fff
>  #define HALO_MPU_VIO_ERR_SRC_SHIFT                   0
>  
> -struct wm_adsp_ops wm_adsp1_ops;
> -struct wm_adsp_ops wm_adsp2_ops[];
> +static struct wm_adsp_ops wm_adsp1_ops;
> +static struct wm_adsp_ops wm_adsp2_ops[];
>  struct wm_adsp_ops wm_halo_ops;
>  
>  struct wm_adsp_buf {

Actually testing these they need to update the implementation as
well.

Will send a patch.

Thanks,
Charles


More information about the Alsa-devel mailing list