[alsa-devel] [PATCH] ALSA: hda: set the 2nd headphone's name to be Headphone2

[Hui Wang]

On 2019/3/6 下午4:10, Jaroslav Kysela wrote:
> Dne 06. 03. 19 v 1:23 Hui Wang napsal(a):
>> On 2019/3/6 上午4:00, Jaroslav Kysela wrote:
>>> Dne 05. 03. 19 v 15:09 Hui Wang napsal(a):
>>>> Recently I saw two Headphones on some HP machines, the 1st Headphone
>>>> comes from the Front Headphone Jack, the 2nd one comes from the Front
>>>> Headset Jack, and the current HDA driver will set the same name to
>>>> them and with different index, just like below:
>>>> 'Headphone Playback Volume'
>>>> 'Headphone Playback Switch'
>>>> 'Headphone Playback Volume' index 1
>>>> 'Headphone Playback Switch' index 1
>>>> 'Front Headphone Jack'
>>>> 'Front Headphone Jack' index 1
>>>>
>>>> This can't be handled by pulseaudio, and pulseaduio already has a
>>>> path analog-output-headphones-2.conf to handle the 2nd headphone, now
>>>> we set the 2nd headphone's name to "Headphone2", leave the other
>>>> headphones unchanged.
>>>>
>>>> The change of hda_auto_parser.c will change the name of Jack.
>>>>
>>>> The change of hda_generic.c will change the name of Volume and Switch.
>>> NAK. I'm afraid, but you're trying to revert the change from 2009:
>>>
>>> commit 668b9652be33510a2a42b290dd335d34d38e2068
>>> Author: Takashi Iwai <tiwai at suse.de>
>>> Date:   Fri Mar 6 10:13:24 2009 +0100
>>>
>>>   ALSA: hda - Create multiple HP / speaker controls with index
>>>
>>>   Create multiple "Headphone" and "Speaker" controls with non-zero index
>>>   numbers instead of "Headphone2", etc.
>>>
>>>   Signed-off-by: Takashi Iwai <tiwai at suse.de>
>>>
>>> I think that PA should be fixed instead try to fix the drivers. The
>>> indexes are exactly designed to distinguish the multiple similar I/O.
>>>
>>> I cannot find any other driver which uses the Headphone2 control name.
>>>
>>> 					Jaroslav
>>>
>> OK, got it.  I tried to add the index to the pulseaudio in Jan, but not
>> finish yet.  If you have time, please take a look at my patches and make
>> a comment on them.
>>
>> https://lists.freedesktop.org/archives/pulseaudio-discuss/2019-January/030761.html
> Your changes seem as a good start. Unfortunately, I don't know PA
> internals, so it would be better, if a PA developer can review those
> patches.
>
> 						Jaroslav

OK, Thanks.