[alsa-devel] [PATCH v2 116/146] ASoC: sof: use modern dai_link style

[Kuninori Morimoto]

Hi Pierre-Louis

> > This is very impertinent comment, but it is possible to allow NULL platform
> > instead of dummy platform by this or similar code ?
> > I guess it is nice for SOF future.
> > I can't test and not familiar with SOF thought...
> > 
> > 	if (link->platforms)
> > 		link->platforms->name = dev_name(sdev->dev);
> 
> It's a good question. To be honest I don't fully understand what this
> 'platform' field is needed for... I was just trying to maintain
> 'as-is' functionality. If anyone has a good explanation on when this
> field might be required and for what purpose, and when it can be made
> optional, I am all ears.

I can try to explain.

Originally "Platform" component is for "DMA" transfer
(But I'm not sure detail. It had been exist when I started to work for ALSA SoC...)
But in many SoC, "CPU" component is doing it.
Some SoC needs special "Platform" in my understanding.

Before, if Card didn't select "Platform",
ALSA SoC had selects "dummy platform" automatically.

Today, if Card didn't select it,
ALSA SoC will just igore it.

I guess you added "dummy platform" patch because SOF had this code

	if (!link->platforms) {
		dev_err(...);
		...
	}
	
This come from my patch, but it is just wrong guess.
I don't remember why I did it, but I thought SOF has it.
I'm not familiar with SOF, but it can accept NULL Platform
if we can fix above code to like this ?

	if (link->platforms)
		link->platforms-> ...

But, selecting dummy Platforms itself is not wrong idea.
# 100% wrong idea was my patch orz

Thank you for your help !!
Best regards
---
Kuninori Morimoto