[alsa-devel] [PATCH v2 116/146] ASoC: sof: use modern dai_link style

Daniel Baluta daniel.baluta at nxp.com
Thu Jun 27 13:47:20 CEST 2019


On Wed, 2019-06-26 at 22:58 +0200, Pierre-Louis Bossart wrote:
> > diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
> > index f485f7f751a1..ee73318135fc 100644
> > --- a/sound/soc/soc-topology.c
> > +++ b/sound/soc/soc-topology.c
> > @@ -1883,7 +1883,7 @@ static int soc_tplg_fe_link_create(struct
> > soc_tplg *tplg,
> >          int ret;
> > 
> >          /* link + cpu + codec */
> > -       link = kzalloc(sizeof(*link) + (2 * sizeof(*dlc)),
> > GFP_KERNEL);
> > +       link = kzalloc(sizeof(*link) + (3 * sizeof(*dlc)),
> > GFP_KERNEL);
> >          if (link == NULL)
> >                  return -ENOMEM;
> > 
> > @@ -1891,9 +1891,11 @@ static int soc_tplg_fe_link_create(struct
> > soc_tplg *tplg,
> > 
> >          link->cpus      = &dlc[0];
> >          link->codecs    = &dlc[1];
> > +       link->platforms = &dlc[2];
> > 
> >          link->num_cpus   = 1;
> >          link->num_codecs = 1;
> > +       link->num_platforms = 1;
> > 
> > Can you please help me figure this out?
> 
> Isn't this fixed by my patch "ASoC: soc-topology: fix modern dai
> link 
> style" applied on 6/13? Looks like the same issue to me.

Yes, this is the same thing. My tree with all NXP i.MX8QXP patches
is a little bit older and did not contain your patch.

Sorry for the noise, everything is looking good now! :)




More information about the Alsa-devel mailing list