[alsa-devel] [PATCH 1/2] device property: Add new array helper

Rafael J. Wysocki rafael at kernel.org
Thu Jun 27 11:17:55 CEST 2019


On Thu, Jun 27, 2019 at 2:15 AM Greg KH <gregkh at linuxfoundation.org> wrote:
>
> On Wed, Jun 26, 2019 at 04:36:10PM +0100, Charles Keepax wrote:
> > It is fairly common to want to read an integer array property
> > that is composed of an unknown number of fixed size integer
> > groups. For example, say each group consists of three values
> > which correspond to the settings for one input on the device
> > and the driver supports several chips with different numbers
> > of inputs.
> >
> > Add a new helper function to provide this functionality, it
> > differs for the existing helpers in that it allows reading a
> > smaller number of values than the full array size and checks
> > that the number of values read is a multiple of the group size.
> >
> > Signed-off-by: Charles Keepax <ckeepax at opensource.cirrus.com>
> > ---
> >  drivers/base/property.c  | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/property.h |  2 ++
> >  2 files changed, 50 insertions(+)
>
> Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

Well, I'm kind of not convinced about this one.

More comments in direct reply to the patch message.


More information about the Alsa-devel mailing list