[alsa-devel] [PATCH 0/2] Fixes for SOF module unload/reload

[Takashi Iwai]

On Wed, 26 Jun 2019 08:29:33 +0200,
Ranjani Sridharan wrote:
> 
> A recent commit "ALSA: hdac: fix memory release for SST and SOF drivers"
> removed the kfree call for the hdac device in
> snd_hdac_ext_bus_device_exit(). This requires that the SOF driver
> also make the hdac_device and hdac_hda_priv device-managed so
> that they can be freed when the SOF module in unloaded. The first
> patch takes care of this change.
> 
> Additionally, because of the above change, the hda_codec is
> device-managed and freeing it in snd_hda_codec_dev_release() leads
> to kernel panic with module unload/reload stress tests. The second
> patch includes the change to avoid freeing hda_codec for ASoC driver.

In such a case, both patch need to be put into a single patch.
Otherwise it leads to a bisection failure.


thanks,

Takashi

> 
> More details for the module unload/reload test failures can be found
> here: https://github.com/thesofproject/linux/issues/966
> 
> Ranjani Sridharan (2):
>   ASoC: SOF: Intel: hda: Make hdac_device device-managed
>   ASoC: hda: don't free hda_codec for HDA_DEV_ASOC type
> 
>  sound/pci/hda/hda_codec.c       | 8 +++++++-
>  sound/soc/sof/intel/hda-codec.c | 6 ++----
>  2 files changed, 9 insertions(+), 5 deletions(-)
> 
> -- 
> 2.17.1
>