[alsa-devel] [PATCH v1] ASoC: Intel: Skylake: Switch to modern UUID API

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Fri Jun 21 05:41:48 CEST 2019


>>>    	char mod_name[64]; /* guid str = 32 chars + 4 hyphens */
>>> -	uuid_le *uuid_mod;
>>> -	uuid_mod = (uuid_le *)guid;
>>>    	snprintf(mod_name, sizeof(mod_name), "%s%pUL%s",
>>> -				"intel/dsp_fw_", uuid_mod, ".bin");
>>> +					     "intel/dsp_fw_", guid, ".bin");
>>
>> indentation looks off, not sure if this is a diff effect.
> 
> Ah, this can be modified to the below (by a separate patch, since Mark applied
> this one already):
> 
> 	snprintf(mod_name, sizeof(mod_name), "intel/dsp_fw_%pUL.bin", guid);
> 
> What do you think?
> 
> P.S. And it will take only one line.

Sounds good to me. Not sure why it was written this way.



More information about the Alsa-devel mailing list