[alsa-devel] [PATCH] ASoC: Intel: sof_rt5682: use GFP_KERNEL instead of GFP_ATOMIC

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Tue Jun 18 09:11:37 CEST 2019


On 6/18/19 9:04 AM, Tzung-Bi Shih wrote:
> Change the memory allocation flag from GFP_ATOMIC to GFP_KERNEL because
> probe of platform device is unlikely a place where cannot sleep.
> 
> Signed-off-by: Tzung-Bi Shih <tzungbi at google.com>
> ---
> It might be a typo introduced from copied-and-pasted.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

We noticed this issue yesterday while reviewing additional changes for 
this machine driver but you beat us to it. Thanks!

> 
>   sound/soc/intel/boards/sof_rt5682.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c
> index e2e5f97d9920..02138aa8a850 100644
> --- a/sound/soc/intel/boards/sof_rt5682.c
> +++ b/sound/soc/intel/boards/sof_rt5682.c
> @@ -498,7 +498,7 @@ static int sof_audio_probe(struct platform_device *pdev)
>   	int dmic_num, hdmi_num;
>   	int ret, ssp_amp, ssp_codec;
>   
> -	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC);
> +	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);
>   	if (!ctx)
>   		return -ENOMEM;
>   
> 



More information about the Alsa-devel mailing list