[alsa-devel] [PATCH] ALSA: hda/realtek: Add quirks for several Clevo notebook barebones

[Takashi Iwai]

On Sat, 15 Jun 2019 05:42:07 +0200,
Richard Sailer wrote:
> 
> This adds 4 SND_PCI_QUIRK(...) lines for several barebone models of the ODM
> Clevo. The model names are written in regex syntax to describe/match all clevo
> models that are similar enough and use the same PCI SSID that this fixup works
> for them.
> 
> Additionally the lines regarding SSID 0x96e1 and 0x97e1 didn't fix audio for the
> all our Clevo notebooks using these SSIDs (models Clevo P960* and P970*) since
> ALC1220_FIXP_CLEVO_PB51ED_PINS swapped pins that are not necesarry to be
> swapped. This patch initiates ALC1220_FIXUP_CLEVO_P950 instead for these model
> and fixes the audio.

Your sign-off is missing.  Could you resubmit with it?

> This is strange since the System76 Oryx Pro also seems to be a P960 and
> P970 barebone, so the original fixup should also not have worked for
> them. @Jeremy: What's your take on this?

... and it's better if this mystery is clarified, too.

Regarding the code change:

> ---
>  sound/pci/hda/patch_realtek.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 1afb268f3da0..61dcd293afb1 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -2461,9 +2461,10 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1558, 0x9501, "Clevo P950HR", ALC1220_FIXUP_CLEVO_P950),
>  	SND_PCI_QUIRK(0x1558, 0x95e1, "Clevo P95xER", ALC1220_FIXUP_CLEVO_P950),
>  	SND_PCI_QUIRK(0x1558, 0x95e2, "Clevo P950ER", ALC1220_FIXUP_CLEVO_P950),
> -	SND_PCI_QUIRK(0x1558, 0x96e1, "System76 Oryx Pro (oryp5)", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> -	SND_PCI_QUIRK(0x1558, 0x97e1, "System76 Oryx Pro (oryp5)", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> -	SND_PCI_QUIRK(0x1558, 0x65d1, "Tuxedo Book XC1509", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> +	SND_PCI_QUIRK(0x1558, 0x96e1, "Clevo P960[ER][CDFN]-K", ALC1220_FIXUP_CLEVO_P950),
> +	SND_PCI_QUIRK(0x1558, 0x97e1, "Clevo P970[ER][CDFN]", ALC1220_FIXUP_CLEVO_P950),
> +	SND_PCI_QUIRK(0x1558, 0x65d1, "Clevo PB51[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> +	SND_PCI_QUIRK(0x1558, 0x67d1, "Clevo PB71[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS),

We don't have to list up necessarily the detailed model names here.
Though, it's OK in this form as it's done concisely.


thanks,

Takashi