[alsa-devel] [PATCH v3 2/5] ALSA: hda: move parts of NHLT code to new module

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Fri Jul 26 17:41:34 CEST 2019



On 7/26/19 7:10 AM, Cezary Rojewski wrote:
> On 2019-07-22 15:44, Pierre-Louis Bossart wrote:
>> Move parts of the code outside of the Skylake driver to help detect
>> the presence of DMICs (which are not supported by the HDaudio legacy
>> driver).
>>
>> No functionality change (except for the removal of useless OR
>> operations), only indentation and checkpatch fixes, and making sure
>> that the code compiles without ACPI
>>
>> Signed-off-by: Pierre-Louis Bossart 
>> <pierre-louis.bossart at linux.intel.com>
> 
> I didn't really see response to previous review apart from CONFIG_ thingy.

I just realize I missed your other comments, will look at them later today.

> - By the way, thanks Takashi for in-depth explanation!
> 
> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-July/152407.html
> 
> Especially the ACPI leak part, though I'd hoped you would jump on my 
> shift-left train too :s
> Although, maybe those changes should be separated from relocation patch 
> and ignored for current series..
> 
> Czarek


More information about the Alsa-devel mailing list