[alsa-devel] [RFC PATCH 06/40] soundwire: intel: prevent possible dereference in hw_params
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Fri Jul 26 16:02:30 CEST 2019
>> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
>> index 68832e613b1e..497879dd9c0d 100644
>> --- a/drivers/soundwire/intel.c
>> +++ b/drivers/soundwire/intel.c
>> @@ -509,7 +509,7 @@ static int intel_config_stream(struct sdw_intel *sdw,
>> struct snd_soc_dai *dai,
>> struct snd_pcm_hw_params *hw_params, int link_id)
>> {
>> - if (sdw->res->ops && sdw->res->ops->config_stream)
>> + if (sdw->res->ops && sdw->res->ops->config_stream && sdw->res->arg)
>> return sdw->res->ops->config_stream(sdw->res->arg,
>> substream, dai, hw_params, link_id);
>>
>
> Hmm, declaring local for sdw->res should prove useful here after
> addition of 4th sdw->res dereference.
yes, it's an eyesore. I added this to quickly fix a kernel oops while
debugging, will simplify. thanks for the note.
More information about the Alsa-devel
mailing list