[alsa-devel] [PATCH] ASoC: soc-topology: use for_each_component_dais() at remove_dai()
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Fri Jul 26 07:43:52 CEST 2019
From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
commit 52abe6cc1866a ("ASoC: topology: fix oops/use-after-free case
with dai driver") fixups remove_dai() error, but it is directly using
list_for_each_entry() for component->dai_list.
We already have for_each_component_dais() macro for it.
Let's use exising method.
Fixes: 52abe6cc1866a ("ASoC: topology: fix oops/use-after-free case
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
---
sound/soc/soc-topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
index 6387803..12c58e3 100644
--- a/sound/soc/soc-topology.c
+++ b/sound/soc/soc-topology.c
@@ -530,7 +530,7 @@ static void remove_dai(struct snd_soc_component *comp,
if (dobj->ops && dobj->ops->dai_unload)
dobj->ops->dai_unload(comp, dobj);
- list_for_each_entry(dai, &comp->dai_list, list)
+ for_each_component_dais(comp, dai)
if (dai->driver == dai_drv)
dai->driver = NULL;
--
2.7.4
More information about the Alsa-devel
mailing list