[alsa-devel] [PATCH 07/25] ASoC: soc-component: add snd_soc_component_hw_free()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Jul 25 03:55:48 CEST 2019


Hi Ranjani

> > @@ -843,11 +843,7 @@ static int soc_pcm_components_hw_free(struct
> > snd_pcm_substream *substream,
> >  		if (component == last)
> >  			break;
> >  
> > -		if (!component->driver->ops ||
> > -		    !component->driver->ops->hw_free)
> > -			continue;
> > -
> > -		component->driver->ops->hw_free(substream);
> > +		snd_soc_component_hw_free(component, substream);
> Morimoto-san,
> 
> Just wondering why we dont care about the return value here. I see that
> the original code ignores the return value too but is it something that
> should be addressed?

Yes, indeed.
Thank you for your feedback.
I will fix up it at v2

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list