[alsa-devel] [PATCH 23/25] ASoC: soc-component: move snd_soc_component_seq_notifier()

[Kuninori Morimoto]

Hi Charles

> > @@ -2736,8 +2728,7 @@ static int snd_soc_component_initialize(struct snd_soc_component *component,
> >  	dapm->bias_level = SND_SOC_BIAS_OFF;
> >  	dapm->idle_bias_off = !driver->idle_bias_on;
> >  	dapm->suspend_bias_off = driver->suspend_bias_off;
> > -	if (driver->seq_notifier)
> > -		dapm->seq_notifier = snd_soc_component_seq_notifier;
> > +	dapm->seq_notifier = snd_soc_component_seq_notifier;
> 
> If we are updating this to always set a seq_notifier would it be
> worth removing the NULL checks in soc-dapm.c? At the moment I
> guess it will end up checking twice, DAPM checks if dapm->seq_notifier
> is NULL but it never will be, then the helper checks if
> driver->seq_notifier is NULL.

Yes, indeed.
I will double-check it, and will fix it at v2

Thank you for your help !!
Best regards
---
Kuninori Morimoto