[alsa-devel] [PATCH 3/3] ASoC: rt1308: Convert headers to SPDX

Shuming [范書銘] shumingf at realtek.com
Mon Jul 22 13:48:52 CEST 2019


> On Mon, Jul 22, 2019 at 02:07:47AM +0000, Shuming [范書銘] wrote:
> > > On Fri, Jul 19, 2019 at 02:33:02PM +0800, shumingf at realtek.com wrote:
> 
> > > > @@ -1,12 +1,10 @@
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > >  /*
> > > >   * rt1308.c  --  RT1308 ALSA SoC amplifier component driver
> > > >   *
> 
> > > Please convert the entire comment block to a C++ one so this looks
> > > more intentional.
> 
> > I convert the comment like below.
> > -// SPDX-License-Identifier: GPL-2.0
> > +/* SPDX-License-Identifier: GPL-2.0 */
> 
> That's a C comment, not a C++ comment.  I'm saying convert the whole block
> there to C++ rather than add one random line that's C++ next to some C
> comments.
> 

May I confirm what your point?
I convert the entire comment block to a C++ one like below.
// SPDX-License-Identifier: GPL-2.0
-/*
- * rt1308.c  --  RT1308 ALSA SoC amplifier component driver
- *
- * Copyright 2019 Realtek Semiconductor Corp.
- * Author: Derek Fang <derek.fang at realtek.com>
- *
- */
+//
+// rt1308.c  --  RT1308 ALSA SoC amplifier component driver
+//
+// Copyright 2019 Realtek Semiconductor Corp.
+// Author: Derek Fang <derek.fang at realtek.com>
+//




More information about the Alsa-devel mailing list