[alsa-devel] [PATCH 1/2] ALSA: hda/hdmi - Don't report spurious jack state changes

Takashi Iwai tiwai at suse.de
Thu Jul 18 14:30:19 CEST 2019


On Thu, 18 Jul 2019 14:21:25 +0200,
Kai Vehmanen wrote:
> 
> Hey,
> 
> On Thu, 18 Jul 2019, Takashi Iwai wrote:
> 
> > The HDMI jack handling reports the state change always via
> > snd_jack_report() whenever hdmi_present_sense() is called, even if the
> > state itself doesn't change from the previous time.  This is mostly
> > harmless but still a big confusing to user-space.
> 
> typo: "a bit confusing to user-space"

Right, corrected now.

> The patch iself looks good. Gave a quick test with some HDMI 
> hotplugging and works as expected.
> 
> Reviewed-by: Kai Vehmanen <kai.vehmanen at linux.intel.com>

Thanks, put now.

I forgot to mention in the cover letter that the latest patches
including radeon and nouveau patches are found in topic/hda-acomp
branch of my sound.git tree.  This is no permanent one, and will be
rebased once after 5.3-rc1 is released.


Takashi


More information about the Alsa-devel mailing list