[alsa-devel] [PATCH] ASoC: fsl_sai: mark regmap as fast_io

Lucas Stach l.stach at pengutronix.de
Wed Jul 17 13:44:16 CEST 2019


Am Mittwoch, den 17.07.2019, 12:06 +0100 schrieb Mark Brown:
> On Wed, Jul 17, 2019 at 12:51:56PM +0200, Lucas Stach wrote:
> 
> > The regmap is only ever used to access MMIO registers, so it's fair
> > to say that register access is fast.
> 
> Are you sure there's no caches that try to do allocations at
> runtime?  The main thing fast_io does is change the locking to
> spinlocks which means we shouldn't do any allocations under lock,
> such as when updating the cache.

This driver is using REGCACHE_FLAT, which does its sole allocation on
init and none at reg access time AFAICS. So this should be okay.

Regards,
Lucas


More information about the Alsa-devel mailing list