[alsa-devel] [PATCH 1/2] ASoC: samsung: odroid: fix an use-after-free issue for codec
Markus Elfring
Markus.Elfring at web.de
Sun Jul 14 10:47:20 CEST 2019
> @@ -317,6 +316,7 @@ static int odroid_audio_probe(struct platform_device *pdev)
> goto err_put_clk_i2s;
> }
>
> + of_node_put(codec);
I would prefer to avoid a bit of duplicate source code also at this place.
Thus I would find a statement like “goto put_node;” more appropriate here.
> return 0;
>
> err_put_clk_i2s:
Regards,
Markus
More information about the Alsa-devel
mailing list