[alsa-devel] [PATCH] ASoC: audio-graph-card: Constify reg in graph_get_dai_id
Nathan Chancellor
natechancellor at gmail.com
Fri Jul 12 03:43:57 CEST 2019
clang errors:
sound/soc/generic/audio-graph-card.c:87:7: error: assigning to 'u32 *'
(aka 'unsigned int *') from 'const void *' discards qualifiers
[-Werror,-Wincompatible-pointer-types-discards-qualifiers]
reg = of_get_property(node, "reg", NULL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Move the declaration up a bit to keep the reverse christmas tree look.
Fixes: c152f8491a8d ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
Link: https://github.com/ClangBuiltLinux/linux/issues/599
Signed-off-by: Nathan Chancellor <natechancellor at gmail.com>
---
sound/soc/generic/audio-graph-card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
index c8abb86afefa..c0d262a2ce2c 100644
--- a/sound/soc/generic/audio-graph-card.c
+++ b/sound/soc/generic/audio-graph-card.c
@@ -62,8 +62,8 @@ static int graph_get_dai_id(struct device_node *ep)
struct device_node *node;
struct device_node *endpoint;
struct of_endpoint info;
+ const u32 *reg;
int i, id;
- u32 *reg;
int ret;
/* use driver specified DAI ID if exist */
--
2.22.0
More information about the Alsa-devel
mailing list