[alsa-devel] [ALSA patch] [PATCH 1/2] alsa: pcm: add unsupported OPS

Takashi Iwai tiwai at suse.de
Tue Jul 9 14:25:00 CEST 2019


On Mon, 08 Jul 2019 13:04:48 +0200,
Adam Miartus wrote:
> 
> From: Andreas Pape <apape at de.adit-jv.com>
> 
> Signed-off-by: Andreas Pape <apape at de.adit-jv.com>
> Signed-off-by: Adam Miartus <amiartus at de.adit-jv.com>

No description isn't good at all.  There must be something you can
explain in details here.

About the changes:

> +#define PCM_UNSUPPORTED_ERR (-ENOSYS)
> +void snd_pcm_unsupported_dump(snd_pcm_t *pcm, snd_output_t *out)
> +{
> +	snd_output_printf(out, "unsupported\n");
> +}

IMO, we don't need to show anything if it's dummy.
And, maybe it's more straightforward to let the PCM core allow NULL
ops?


thanks,

Takashi


More information about the Alsa-devel mailing list