[alsa-devel] [PATCH 5/7] ALSA: firewire-lib: code refactoring for error path of parser for CIP header
Takashi Sakamoto
o-takashi at sakamocchi.jp
Sun Jul 7 14:07:57 CEST 2019
When a parser for CIP header returns -EAGAIN, no extra care is needed
to probe tracepoints event.
This commit adds code refactoring for the error path.
Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
---
sound/firewire/amdtp-stream.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c
index 24cc8ce51e01..8c4564a560f6 100644
--- a/sound/firewire/amdtp-stream.c
+++ b/sound/firewire/amdtp-stream.c
@@ -635,12 +635,8 @@ static int parse_ir_ctx_header(struct amdtp_stream *s, unsigned int cycle,
cip_header = ctx_header + 2;
err = check_cip_header(s, cip_header, *payload_length,
data_blocks, dbc, syt);
- if (err < 0) {
- if (err != -EAGAIN)
- return err;
-
- *data_blocks = 0;
- }
+ if (err < 0)
+ return err;
} else {
cip_header = NULL;
err = 0;
@@ -654,9 +650,6 @@ static int parse_ir_ctx_header(struct amdtp_stream *s, unsigned int cycle,
*dbc = 0;
}
- if (err < 0)
- return err;
-
s->data_block_counter = *dbc;
trace_amdtp_packet(s, cycle, cip_header, *payload_length, *data_blocks,
--
2.20.1
More information about the Alsa-devel
mailing list