[alsa-devel] [PATCH v2 07/23] ASoC: au1x: psc-ac97.c: use devm_snd_soc_register_component()

[Kuninori Morimoto]

Hi Mark

> > @@ -426,8 +426,6 @@ static int au1xpsc_ac97_drvremove(struct platform_device *pdev)
> >  {
> >  	struct au1xpsc_audio_data *wd = platform_get_drvdata(pdev);
> >  
> > -	snd_soc_unregister_component(&pdev->dev);
> > -
> >  	/* disable PSC completely */
> >  	__raw_writel(0, AC97_CFG(wd));
> >  	wmb(); /* drain writebuffer */
> 
> I don't think this is 100% safe - with this change we will turn
> off the hardware block before we unregister the component which
> means that we might try to interact with it.  If we're converting
> to devm then we need to be careful the ordering of the removal
> won't be affected.

Hmm indeed.
Thank you for your review.

Thank you for your help !!
Best regards
---
Kuninori Morimoto