[alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Thu Jan 24 20:07:17 CET 2019
>> changes are legitimate. To move forward, maybe it's not worth spending too
>> much time on a grand unification of string theory, there are simpler
>> solutions: the Intel machine drivers already do get the platform driver name
>> as an platform_data argument, so we could modify the dailinks platform names
>> before even registering the card. I tested with the attached
> Yes, that would be much better - it's vastly more idiomatic. The
> general idea is that a machine driver should know what it's expecting to
> find before it starts probing.
Thanks for the feedback, will send a formal patch with the helper and
machine driver changes after I test more with the legacy drivers. Do you
have a preference for one patch that deals with multiple machines
drivers in one shot, or individual patches? The latter are nicer for
backports (e.g. for Chrome), the former nicer for maintainers...
The goal of reusing machine drivers as is isn't really achievable
anyways, it looks like we are going to have additional changes, e.g. if
we want to avoid the calls to snd_pcm_suspend as suggested by Takashi,
we'll have to add a reference to snd_soc_pm_ops that's only used for
SOF, the Atom/SST driver does things in different ways mostly due to
historical reasons.
-Pierre
More information about the Alsa-devel
mailing list