[alsa-devel] [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement

[Jon Hunter]

On 11/01/2019 00:52, Kuninori Morimoto wrote:

...

>> It is still fragile. Again the machine driver could have incorrectly set
>> these 'allocated_platform/codecs' members as they are exposed to the
>> machine driver. You have no way to determine if the machine driver is
>> doing the correct thing or not. The problem becomes more complex with
>> probe deferral.
> 
> Indeed there is such case so far, but my understanding is that current
> driver should select "legacy style" or "modern style".
> If driver setup it as "legacy", but access to "modern" member,
> it is driver side bug, right ?

Yes absolutely it is a driver bug, but looking at the snd_soc_dai_link
structure today it is not clear what the driver should be setting and
what is 'modern' and what is 'legacy'. You need to dig through the git
history and code to figure this out. So you could say it is not very
well documented/commented from a soc-core perspective and could be easy
for a driver writer to get themselves in a pickle/mess. Anyway, that is
easy to fix and we could add some comments to clear it up.

Cheers
Jon

-- 
nvpublic