[alsa-devel] [PATCH 19/21] ASoC: da7219: use logical AND

[Adam Thomson]

On 05 January 2019 02:03, Pierre-Louis Bossart wrote:

> Reported by Sparse:
> da7219.c:841:57: warning: dubious: x & !y
> 
> Cc: Adam Thomson <Adam.Thomson.Opensource at diasemi.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource at diasemi.com>

> ---
>  sound/soc/codecs/da7219.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index
> ce165047b9f9..513ec0368653 100644
> --- a/sound/soc/codecs/da7219.c
> +++ b/sound/soc/codecs/da7219.c
> @@ -838,7 +838,7 @@ static int da7219_dai_event(struct snd_soc_dapm_widget
> *w,
>  				++i;
>  				msleep(50);
>  			}
> -		} while ((i < DA7219_SRM_CHECK_RETRIES) & (!srm_lock));
> +		} while ((i < DA7219_SRM_CHECK_RETRIES) && (!srm_lock));
> 
>  		if (!srm_lock)
>  			dev_warn(component->dev, "SRM failed to lock\n");
> --
> 2.17.1