[alsa-devel] [PATCH 10/10] ASoC: Intel: Add ACPI match table entry for ES8316 codec on BYTCR platform

[Hans de Goede]

Hi,

On 03-01-19 17:43, Pierre-Louis Bossart wrote:
> 
> On 1/3/19 7:45 AM, Hans de Goede wrote:
>> Some BYTCR devices use an ES8316 codec, add an ACPI match table entry
>> for this.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>   sound/soc/intel/common/soc-acpi-intel-byt-match.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/sound/soc/intel/common/soc-acpi-intel-byt-match.c b/sound/soc/intel/common/soc-acpi-intel-byt-match.c
>> index 027dc27262b7..96f9c553fe6c 100644
>> --- a/sound/soc/intel/common/soc-acpi-intel-byt-match.c
>> +++ b/sound/soc/intel/common/soc-acpi-intel-byt-match.c
>> @@ -185,6 +185,15 @@ struct snd_soc_acpi_mach  snd_soc_acpi_intel_baytrail_machines[] = {
>>           .sof_tplg_filename = "intel/sof-byt-da7213.tplg",
>>           .asoc_plat_name = "sst-mfld-platform",
>>       },
>> +    {
>> +        .id = "ESSX8316",
>> +        .drv_name = "bytcht_es8316",
>> +        .fw_filename = "intel/fw_sst_0f28.bin",
>> +        .board = "bytcht_es8316",
> 
> Coming from the holiday break I saw this .board field and couldn't recall why we needed it. None of the more recent boards set this field. Is this legacy stuff that isn't used by anyone?

I would expect you to know that better then I do :)  I just copied this from the
other entries.

If you want to submit a patch removing the .board entries I'm all for it.

Regards,

Hans



> 
> 
>> +        .sof_fw_filename = "intel/sof-byt.ri",
>> +        .sof_tplg_filename = "intel/sof-byt-es8316.tplg",
>> +        .asoc_plat_name = "sst-mfld-platform",
>> +    },
>>       /* some Baytrail platforms rely on RT5645, use CHT machine driver */
>>       {
>>           .id = "10EC5645",