[alsa-devel] [PATCH] ALSA: firewire-motu: fix construction of PCM frame for capture direction

Takashi Iwai tiwai at suse.de
Tue Feb 26 07:12:56 CET 2019


On Tue, 26 Feb 2019 05:38:37 +0100,
Takashi Sakamoto wrote:
> 
> In data blocks of common isochronous packet for MOTU devices, PCM
> frames are multiplexed in a shape of '24 bit * 4 Audio Pack', described
> in IEC 61883-6. The frames are not aligned to quadlet.
> 
> For capture PCM substream, ALSA firewire-motu driver constructs PCM
> frames by reading data blocks byte-by-byte. However this operation
> includes bug for lower byte of the PCM sample. This brings invalid
> content of the PCM samples.
> 
> This commit fixes the bug.
> 
> Reported-by: Peter Sjöberg <autopeter at gmail.com>
> Cc: <stable at vger.kernel.org> # v4.12+
> Fixes: 4641c9394010 ("ALSA: firewire-motu: add MOTU specific protocol layer")
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

Applied, thanks.


Takashi


More information about the Alsa-devel mailing list