[alsa-devel] [PATCH v4 07/14] ASoC: SOF: Add DSP firmware logger support

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Wed Feb 20 21:18:01 CET 2019


On 2/20/19 11:44 AM, Mark Brown wrote:
> On Wed, Feb 13, 2019 at 04:07:27PM -0600, Pierre-Louis Bossart wrote:
>
>> +	/* make sure count is <= avail */
>> +	count = avail > count ? count : avail;
> count = min(avail, count)?
as discussed in the last review, we didn't use min() since it adds a 
number of obscure warnings with sparse. I haven't found any time to look 
into this so for now left the code as is. Sparse is a useful tool for 
the address checks (topology/DMAs with _le32, __iomem, etc), the fewer 
warnings we get the better.


More information about the Alsa-devel mailing list