[alsa-devel] [PATCH 6/6] ASoC: samsung: Fix of-node refcount unbalance in odroid_audio_probe()

Takashi Iwai tiwai at suse.de
Wed Feb 20 11:40:24 CET 2019


On Tue, 19 Feb 2019 17:36:56 +0100,
Sylwester Nawrocki wrote:
> 
> On 2/19/19 16:46, Takashi Iwai wrote:
> > odroid_audio_probe() leaves of-nodes without unreferenced after use.
> > Fix it by shuffling some code a bit and add the missing of_node_put()
> > calls accordingly.
> > 
> > Fixes: aba611fc4c69 ("ASoC: samsung: Add Odroid ASoC machine driver")
> > Cc: Krzysztof Kozlowski <krzk at kernel.org>
> > Cc: Sangbeom Kim <sbkim73 at samsung.com>
> > Cc: Sylwester Nawrocki <s.nawrocki at samsung.com>
> > Signed-off-by: Takashi Iwai <tiwai at suse.de>
> > ---
> > 
> > Only compile-tested.  Please review carefully.  Thanks!
> Thanks for the patch. Current code for 5.1 is a bit different and we 
> may now need something like:

Ah thanks, I forgot to follow asoc repo since merging to sound.git
tree in this regard.

Care to submit the patch for the latest tree from your side?


Thanks!

Takashi


More information about the Alsa-devel mailing list