[alsa-devel] [PATCH v2 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_SCALE()

Andrew F. Davis afd at ti.com
Tue Feb 19 18:05:24 CET 2019


On 2/19/19 10:29 AM, Codrin.Ciubotariu at microchip.com wrote:
> From: Codrin Ciubotariu <codrin.ciubotariu at microchip.com>
> 
> According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step.
> Tested on pcm1863.
> 
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu at microchip.com>
> ---

Acked-by: Andrew F. Davis <afd at ti.com>

> 
> Changes in v2:
>  - fixed title - added correct macro;
>  - revert the removal of a new line;
> 
>  sound/soc/codecs/pcm186x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c
> index 809b7e9f03ca..c36a391fec8a 100644
> --- a/sound/soc/codecs/pcm186x.c
> +++ b/sound/soc/codecs/pcm186x.c
> @@ -42,7 +42,7 @@ struct pcm186x_priv {
>  	bool is_master_mode;
>  };
>  
> -static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 4000, 50);
> +static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 50, 0);
>  
>  static const struct snd_kcontrol_new pcm1863_snd_controls[] = {
>  	SOC_DOUBLE_R_S_TLV("ADC Capture Volume", PCM186X_PGA_VAL_CH1_L,
> 


More information about the Alsa-devel mailing list