[alsa-devel] [PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_LINEAR()

Codrin.Ciubotariu at microchip.com Codrin.Ciubotariu at microchip.com
Tue Feb 19 17:20:41 CET 2019


On 19.02.2019 18:15, Codrin Ciubotariu - M19940 wrote:
> From: Codrin Ciubotariu <codrin.ciubotariu at microchip.com>
> 
> According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step.
> Tested on pcm1863.
> 
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu at microchip.com>
> ---
>   sound/soc/codecs/pcm186x.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c
> index 809b7e9f03ca..7947279243f9 100644
> --- a/sound/soc/codecs/pcm186x.c
> +++ b/sound/soc/codecs/pcm186x.c
> @@ -6,7 +6,6 @@
>    *	Andreas Dannenberg <dannenberg at ti.com>
>    *	Andrew F. Davis <afd at ti.com>
>    */
> -
>   #include <linux/module.h>
>   #include <linux/moduleparam.h>
>   #include <linux/init.h>
> @@ -42,7 +41,7 @@ struct pcm186x_priv {
>   	bool is_master_mode;
>   };
>   
> -static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 4000, 50);
> +static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 50, 0);
>   
>   static const struct snd_kcontrol_new pcm1863_snd_controls[] = {
>   	SOC_DOUBLE_R_S_TLV("ADC Capture Volume", PCM186X_PGA_VAL_CH1_L,
> 

the title is wrong, there is no DECLARE_TLV_DB_LINEAR()present. Will 
send v2.

Best regards,
Codrin


More information about the Alsa-devel mailing list