[alsa-devel] [PATCH] ASoC: simple-card: fixup refcount_t underflow

[Daniel Baluta]

Hi,

This patch doesn't seem to apply on Mark's sound/for-next branch.

What is the tree you based this on?

thanks,
Daniel.
On Fri, Feb 15, 2019 at 8:43 AM Kuninori Morimoto
<kuninori.morimoto.gx at renesas.com> wrote:
>
>
> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>
> commit da215354eb55c ("ASoC: simple-card: merge simple-scu-card")
> merged simple-card and simple-scu-card. Then it had refcount
> underflow bug. This patch fixup it.
> We will get below error without this patch.
>
>         OF: ERROR: Bad of_node_put() on /sound
>         CPU: 3 PID: 237 Comm: kworker/3:1 Not tainted 5.0.0-rc6+ #1514
>         Hardware name: Renesas H3ULCB Kingfisher board based on r8a7795 ES2.0+ (DT)
>         Workqueue: events deferred_probe_work_func
>         Call trace:
>          dump_backtrace+0x0/0x150
>          show_stack+0x24/0x30
>          dump_stack+0xb0/0xec
>          of_node_release+0xd0/0xd8
>          kobject_put+0x74/0xe8
>          of_node_put+0x24/0x30
>          __of_get_next_child+0x50/0x70
>          of_get_next_child+0x40/0x68
>          asoc_simple_card_probe+0x604/0x730
>          platform_drv_probe+0x58/0xa8
>          ...
> Reported-by: Vicente Bergas <vicencb at gmail.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> ---
> Vicente, can you please test this patch ?
>
>  sound/soc/generic/simple-card.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
> index 37e001c..3fe3441 100644
> --- a/sound/soc/generic/simple-card.c
> +++ b/sound/soc/generic/simple-card.c
> @@ -462,7 +462,7 @@ static int asoc_simple_card_parse_of(struct simple_card_data *priv)
>         conf_idx        = 0;
>         node = of_get_child_by_name(top, PREFIX "dai-link");
>         if (!node) {
> -               node = dev->of_node;
> +               node = of_node_get(top);
>                 loop = 0;
>         }
>
> --
> 2.7.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel