[alsa-devel] [PATCH] ASoC: simple-card: fixup refcount_t underflow

[Mark Brown]

On Fri, Feb 15, 2019 at 06:48:26PM +0200, Daniel Baluta wrote:

> --- a/sound/soc/generic/simple-card.c
> +++ b/sound/soc/generic/simple-card.c
> @@ -445,7 +445,7 @@ static int simple_for_each_link(struct simple_priv *priv,
>         /* Check if it has dai-link */
>         node = of_get_child_by_name(top, PREFIX "dai-link");
>         if (!node) {
> -               node = top;
> +               node = of_node_get(top);
>                 is_top = 1;
>         }
> 
> Not sure if is correct, though.

That looks correct to me, of_get_child_by_name() takes a reference we'll
need to drop later so when we substitute in top we need to take a
reference as well as just assigning.  Can you or someone put together a
proper patch please?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20190215/067800cc/attachment.sig>