[alsa-devel] [PATCH v2 01/20] ASoC: SOF: Intel: Add BYT, CHT and BSW DSP HW support.

[Takashi Iwai]

On Wed, 13 Feb 2019 23:08:28 +0100,
Pierre-Louis Bossart wrote:
> 
> +static irqreturn_t byt_irq_thread(int irq, void *context)
> +{
> +	struct snd_sof_dev *sdev = (struct snd_sof_dev *)context;
> +	u64 ipcx, ipcd;
> +	u64 imrx;
> +
> +	imrx = snd_sof_dsp_read64(sdev, BYT_DSP_BAR, SHIM_IMRX);
> +	ipcx = snd_sof_dsp_read64(sdev, BYT_DSP_BAR, SHIM_IPCX);
> +
> +	/* reply message from DSP */
> +	if (ipcx & SHIM_BYT_IPCX_DONE &&
> +	    !(imrx & SHIM_IMRX_DONE)) {
> +		/* Mask Done interrupt before first */
> +		snd_sof_dsp_update_bits64_unlocked(sdev, BYT_DSP_BAR,
> +						   SHIM_IMRX,
> +						   SHIM_IMRX_DONE,
> +						   SHIM_IMRX_DONE);

Is it safe to use unlocked call here?  It's a question also in general
for other places found in this patch.


thanks,

Takashi