[alsa-devel] [PATCH v4 02/14] ASoC: SOF: Add Sound Open Firmware KControl support

[Takashi Iwai]

On Wed, 13 Feb 2019 23:07:22 +0100,
Pierre-Louis Bossart wrote:
> 
> +int snd_sof_bytes_ext_put(struct snd_kcontrol *kcontrol,
> +			  const unsigned int __user *binary_data,
> +			  unsigned int size)
> +{
> +	struct soc_bytes_ext *be =
> +		(struct soc_bytes_ext *)kcontrol->private_value;
> +	struct snd_sof_control *scontrol = be->dobj.private;
> +	struct snd_sof_dev *sdev = scontrol->sdev;
> +	struct sof_ipc_ctrl_data *cdata = scontrol->control_data;
> +	struct snd_ctl_tlv header;
> +	const struct snd_ctl_tlv __user *tlvd =
> +		(const struct snd_ctl_tlv __user *)binary_data;
....

Do we keep supporting TLV-typed ext access in SOF?
This seems to be disliked nowadays (since it's a sort of abuse of TLV
API), and we agreed for dropping / reducing it.


thanks,

Takashi