[alsa-devel] [PATCH] ALSA: usb-audio: Fix implicit fb endpoint setup by quirk

[Manuel Reinhardt]

Am Donnerstag, den 07.02.2019, 08:24 +0100 schrieb Takashi Iwai:
> On Thu, 31 Jan 2019 15:32:35 +0100,
> manuel.rhdt at gmail.com wrote:
> > The commit a60945fd08e4 ("ALSA: usb-audio: move implicit fb quirks
> > to
> > separate function") introduced an error in the handling of quirks
> > for
> > implicit feedback endpoints. This commit fixes this.
> > 
> > If a quirk successfully sets up an implicit feedback endpoint, usb-
> > audio
> > no longer tries to find the implicit fb endpoint itself.
> > 
> > Signed-off-by: Manuel Reinhardt <manuel.rhdt at gmail.com>
> 
> I seem to have overlooked this one, and will queue it.
> 
> BTW, did you hit actually a regression by the mentioned commit?
> Or is just a theoretical fix?

I am in the process of writing a quirk to support the MOTU Microbook II
device. The fix I submitted is necessary for the device to work. I
would be surprised if the fix doesn't also fix regressions with other
devices that require the implicit fb quirk.

I will submit the rest of the code needed for Microbook II support
soon. I mailed this patch first to become acquainted with the linux
patch submission model.

Best,

Manuel