[alsa-devel] [PATCH 0/2 v4] ALSA: pcm: anonymous dup implementation

[Phil Burk]

Thanks for these patches for tinyalsa.  Looks great!

I made a few minor comments on the code layout.
https://github.com/perexg/tinyalsa/commit/f62b953f37693e8426ee4c20e53baae757ba1026
Can you see them?

Phil Burk

On Mon, Feb 4, 2019 at 1:39 AM Jaroslav Kysela <perex at perex.cz> wrote:

> This patchset contains the anonymous dup implementation with permissions
> checking for the ALSA's PCM interface in kernel to enable the restricted
> DMA sound buffer sharing for the restricted tasks.
>
> The code was tested through qemu and it seems to be pretty stable.
>
> The initial tinyalsa implementation can be found here:
>
>   https://github.com/perexg/tinyalsa/commits/anondup
>
> v2 of the patches:
>
> - change clone parameter to subdevice number for the pcm attach
> - change SNDRV_PCM_PERM_MAX to SNDRV_PCM_PERM_MASK
> - the tinyalsa implementation was a little updated (restructured)
>
> v3 of the patches:
>
> - group integer declarations in snd_pcm_anonymous_dup()
> - replaced substream->pcm with pcm in snd_pcm_anonymous_dup()
> - added SNDRV_PCM_PERM_RW check for read/write/readv/writev syscalls
>
> v4 of the patches:
>
> - more simple restriction control (only two modes - full/buffer)
> - the tinyalsa implementation follows this change
>
> Cc: Phil Burk <philburk at google.com>
> Cc: Zach Riggle <riggle at google.com>
> Cc: Mark Brown <broonie at kernel.org>
> Cc: Leo Yan <leo.yan at linaro.org>
> Cc: Baolin Wang <baolin.wang at linaro.org>
>
> Jaroslav Kysela (2):
>   ALSA: pcm: implement the anonymous dup (inode file descriptor)
>   ALSA: pcm: implement the mmap buffer mode for the anonymous dup
>
>  include/sound/pcm.h         | 10 +++--
>  include/uapi/sound/asound.h |  6 ++-
>  sound/core/oss/pcm_oss.c    |  2 +-
>  sound/core/pcm.c            | 13 +++---
>  sound/core/pcm_compat.c     |  1 +
>  sound/core/pcm_native.c     | 97
> ++++++++++++++++++++++++++++++++++++++++++---
>  6 files changed, 110 insertions(+), 19 deletions(-)
>
> --
> 2.13.6
>