[alsa-devel] [PATCH v2 1/2] ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier

[Charles Keepax]

On Wed, Feb 06, 2019 at 01:06:36PM -0600, James Schulman wrote:
> Add driver support for Cirrus Logic CS35L36 boosted
> speaker amplifier
> 
> Signed-off-by: James Schulman <james.schulman at cirrus.com>
> Reviewed-by: Charles Keepax <ckeepax at opensource.cirrus.com>
> Acked-by: Brian Austin <brian.austin at cirrus.com>
> ---
>  include/sound/cs35l36.h    |   43 +
>  sound/soc/codecs/Kconfig   |    5 +
>  sound/soc/codecs/Makefile  |    2 +
>  sound/soc/codecs/cs35l36.c | 1960 ++++++++++++++++++++++++++++++++++++++++++++
>  sound/soc/codecs/cs35l36.h |  446 ++++++++++
>  5 files changed, 2456 insertions(+)
>  create mode 100644 include/sound/cs35l36.h
>  create mode 100644 sound/soc/codecs/cs35l36.c
>  create mode 100644 sound/soc/codecs/cs35l36.h
> 
> diff --git a/include/sound/cs35l36.h b/include/sound/cs35l36.h
> new file mode 100644
> index 0000000..f1cf121
> --- /dev/null
> +++ b/include/sound/cs35l36.h
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * linux/sound/cs35l36.h -- Platform data for CS35L36
> + *
> + * Copyright 2018 Cirrus Logic, Inc.
> + *
> + * Author: James Schulman <james.schulman at cirrus.com>
> + *
> + */

This isn't quite right you should still be using /* */ for the
SPDX in header files.

> diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c
> new file mode 100644
> index 0000000..261bc0b
> --- /dev/null
> +++ b/sound/soc/codecs/cs35l36.c
> @@ -0,0 +1,1960 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * cs35l36.c -- CS35L36 ALSA SoC audio driver
> + *
> + * Copyright 2018 Cirrus Logic, Inc.
> + *
> + * Author: James Schulman <james.schulman at cirrus.com>
> + *
> + */

And Mark will have wanted all of this as a C++ comment.

See this patch for a good example of the advised style:

commit ba34f253711a8427d2ef29475afe406b2d6e5118
ASoC: nau8822: convert to SPDX identifiers

Thanks,
Charles