[alsa-devel] [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks

[Jaroslav Kysela]

Dne 5.2.2019 v 20:42 Takashi Iwai napsal(a):
> Hi,
> 
> this is yet another patchset for trivial cleanups.
> At this time, it's about the superfluous error check from
> snd_pcm_lib_preallocate_pages() and co.  They always succeed and never
> return a failure although many codes do the error check.  The patches
> simply remove the error checks and finally change the function to be
> void function.
> 
> The patches are applied on top of my previous NULL device fix patches,
> so not applicable to ASoC tree, I guess.  As all these are trivial,
> applying through my tree altogether would be simpler.
> 
> So, Mark, please give your ACK if the changes to ASoC drivers are OK.

With all respects, do we really need to split those elementary changes
to single patches inside the sound tree? I would really prefer to have
this inside one patch or maybe few patches (core/pci/asoc/others). Just
my two cents.

Reviewed-by: Jaroslav Kysela <perex at perex.cz>

					Jaroslav

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.