[alsa-devel] [PATCH v3 2/2] ASoC: dapm: harden use of lookup tables

[Pierre-Louis Bossart]

>> +	WARN_ONCE(ARRAY_SIZE(dapm_up_seq) != SND_SOC_DAPM_TYPE_LAST,
>> +		  "bad size for dapm_up_seq, expected %d\n",
>> +		  SND_SOC_DAPM_TYPE_LAST);
>> +
>> +	WARN_ONCE(ARRAY_SIZE(dapm_down_seq) != SND_SOC_DAPM_TYPE_LAST,
>> +		  "bad size for dapm_down_seq, expected %d\n",
>> +		  SND_SOC_DAPM_TYPE_LAST);
> Would BUILD_BUG_ON() work for these instead?
> It's not available, but if it works, better than the runtime check.

I misunderstood your earlier email then. I also felt testing a constant 
all the time wasn't necessarily very optimal, but since you mentioned 
WARN I used it for all cases.

Are you saying use WARN_ONCE for the uninitialized values and 
BUILD_BUG_ON for the array size check?

Thanks!