[alsa-devel] [PATCH 1/6] ASoC: amd: Refactoring of DAI from DMA driver

[RAVULAPATI, VISHNU VARDHAN RAO]

[AMD Official Use Only - Internal Distribution Only]



Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: Mark Brown <broonie at kernel.org>
Sent: Saturday 28 December 2019, 4:26 AM
To: RAVULAPATI, VISHNU VARDHAN RAO
Cc: Deucher, Alexander; djkurtz at google.com; pierre-louis.bossart at linux.intel.com; Liam Girdwood; Jaroslav Kysela; Takashi Iwai; Mukunda, Vijendar; YueHaibing; Kuninori Morimoto; Dan Carpenter; open list; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...
Subject: Re: [PATCH 1/6] ASoC: amd: Refactoring of DAI from DMA driver

On Fri, Dec 27, 2019 at 06:20:50PM +0530, Ravulapati Vishnu vardhan rao wrote:
> ASoC: PCM DMA driver should only have dma ops.
> So Removed all DAI related functionality.Refactoring
> the PCM DMA diver code.Added new file containing only DAI ops

This breaks the build:

It's unfortunate.i noticed but applied the same in 2/6 assuming that the same as 1/6.

  CC      sound/soc/amd/raven/acp3x-i2s.o
In file included from sound/soc/amd/raven/pci-acp3x.c:13:
sound/soc/amd/raven/acp3x.h: In function ‘acp_get_byte_count’:
sound/soc/amd/raven/acp3x.h:94:19: error: ‘SNDRV_PCM_STREAM_PLAYBACK’ undeclared (first use in this function)
  if (direction == SNDRV_PCM_STREAM_PLAYBACK) {
                   ^~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/amd/raven/acp3x.h:94:19: note: each undeclared identifier is reported only once for each function it appears in