[alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers

Marek Szyprowski m.szyprowski at samsung.com
Fri Dec 20 10:05:52 CET 2019


Hi All,

On 20.12.2019 09:28, Marek Szyprowski wrote:
> On 19.12.2019 20:16, Mark Brown wrote:
>> On Thu, Dec 19, 2019 at 02:41:17PM +0100, Marek Szyprowski wrote:
>>> On 19.12.2019 14:05, Mark Brown wrote:
>>>> You can't trigger this via any other mechanism, all the other controls
>>>> are fine?  There's *clearly* no issue with what the commit is doing,
>>>> it's just flagging up that the card is not set.
>>> I've cherrypicked the $subject commit onto vanilla v5.5-rc1 and the
>>> issue is same.
>> Yeah, there were a lot of refactorings in the last merge window so that
>> doesn't entirely surprise me.  The commit should backport futher than
>> that I think?
>
> I've tried initially to cherry-pick it to v5.4, but the the code 
> didn't compile due to lack of some macros, so I've gave up trying. I 
> will check that now and backport needed macros too if you think this 
> would help.

Same issue. I've tried backporting it to each kernel release: 5.4, 5.3, 
5.2, 5.1 and 5.0 (with additional backporting "ASoC: core: add 
SND_SOC_BYTES_E" and "ASoC: Define a set of DAPM pre/post-up events"). 
In all cases the lockdep warning and oops is the same. Backporting to 
v4.9 requires more changes to get it even compiled, so I gave up.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland



More information about the Alsa-devel mailing list